Pass preferred amulet package in Expired(Locked)AmuletTrigger submissions#5463
Open
julientinguely-da wants to merge 4 commits intomainfrom
Open
Pass preferred amulet package in Expired(Locked)AmuletTrigger submissions#5463julientinguely-da wants to merge 4 commits intomainfrom
julientinguely-da wants to merge 4 commits intomainfrom
Conversation
…n [ci] Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
Contributor
moritzkiefer-da
left a comment
There was a problem hiding this comment.
we need the same for the non-locked one. probably also worth adding a test for it
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
…ulien/8330-pass-preferred-pids-expire-locked-amulet
Contributor
Author
might not be so trivial; I've tried creating a test where sv1 is on amulet@0.1.17 and alice on 0.1.16, but they fail to expire. And the logical_sync_upgrade test fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of https://github.com/DACH-NY/cn-test-failures/issues/8330
[ci]
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines