fix: lint root pulumi package sources#5472
Open
samsondav wants to merge 1 commit intocanton-network:mainfrom
Open
fix: lint root pulumi package sources#5472samsondav wants to merge 1 commit intocanton-network:mainfrom
samsondav wants to merge 1 commit intocanton-network:mainfrom
Conversation
Signed-off-by: Sam Davies <sam@avrofi.com>
samsondav
force-pushed
the
sam-avro/issue-3334-pulumi-lint
branch
from
f441164 to
d4992ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cluster/pulumiformat/lint scripts accept file arguments while preserving workspace-wide behavior for normal package runstypescriptfmtpre-commit exclusion for root Pulumi TypeScript filesCloses #3334
Test plan
python3 scripts/fix-ts.py cluster/pulumi/jest.config.ts cluster/pulumi/pulumi.ts cluster/pulumi/pulumiDown.ts cluster/pulumi/pulumiOperations.ts cluster/pulumi/purge_unused_dbs.ts cluster/pulumi/resolvedConfigEmitter.tsnpm run checkfromcluster/pulumisource .envrc.vars; source cluster/deployment/mock/.envrc.vars; make cluster/pulumi/test -j8