Skip to content

remove unneeded divergence from Canton sources#5480

Draft
stephencompall-DA wants to merge 2 commits intomainfrom
s11/546-undo-unneeded-canton-divergence
Draft

remove unneeded divergence from Canton sources#5480
stephencompall-DA wants to merge 2 commits intomainfrom
s11/546-undo-unneeded-canton-divergence

Conversation

@stephencompall-DA
Copy link
Copy Markdown
Contributor

Part of #546.

  • remove SharedCantonConfig#name
  • move Environment#createConsole back where it was

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant