Closed
Conversation
daogrady
commented
Jan 29, 2026
| assert.strictEqual(openAPI.paths["/F1"].get["x-sap-deprecated-operation"].notValidKey, undefined); | ||
| }); | ||
|
|
||
| test('emits *:cds.compile.to.openapi events', async () => { |
Contributor
Author
There was a problem hiding this comment.
These triggered
Async arrow function has no 'await' expression.eslintrequire-await
Member
|
@daogrady I'm wondering whether we should even drop the |
Contributor
Author
|
I am perfectly fine with increasing the limit or switching off this rule completely. |
Contributor
Author
|
Superseded by #138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily targets
max-leneslint warnings, which polluted the PR review view.We can considerably cut back on these warnings by introducing line breaks between sub-expressions, and introducing a few
// eslint-ignore-next-lines for long strings.A few changes are somewhat questionable, like breaking long boolean expressions. We can revert those, if they appear to be too erratic.
I also did not touch conditions inside
ifstatements, that looked very unclean. But we should look into them at some point.