Conversation
There was a problem hiding this comment.
The PR introduces a new MTX ORD provider service with two substantive bugs: req.document (always undefined) is passed instead of req.data.resource to getMetadata, which will silently break the getOrdResource action; and inconsistent optional chaining on req._ between the two handlers means getOrdResource can throw a TypeError in non-HTTP contexts. Both issues should be addressed before merging.
PR Bot Information
Version: 1.18.5 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- Correlation ID:
7aabcd70-213c-11f1-8fd3-42704edda460 - Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.6-sonnet - Agent Instructions:
ce63a52 to
f3f800c
Compare
f3f800c to
2f81e27
Compare
There was a problem hiding this comment.
The PR introduces a useful MTX ORD provider service, but has several correctness issues that need attention: the MtxOrdProviderService needs to be blocklisted to prevent it from appearing as a spurious ORD API resource; both action handlers lack error handling; and cds.services["cds.xt.ModelProviderService"] should use the idiomatic cds.connect.to() pattern to avoid crashes when the service is not yet available.
PR Bot Information
Version: 1.18.5 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- Correlation ID:
d0ab9ac0-2155-11f1-978d-6e6a2209012e - LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
issue_comment.created - Agent Instructions:
6829b14 to
99641c2
Compare
SummaryThe following content is AI-generated and provides a summary of the pull request: Introduce MTX ORD Provider ServiceNew Feature✨ Adds a new MTX (Multi-Tenancy Extension) ORD (Open Resource Discovery) provider service that exposes endpoints for retrieving ORD documents and resources in a multi-tenant context. Changes
PR Bot InformationVersion:
💌 Have ideas or want to contribute? Create an issue and share your thoughts with us! Made with ❤️ by Hyperspace. |
There was a problem hiding this comment.
The PR introduces a useful MTX sidecar ORD provider service, but has three substantive issues: cds.connect.to is invoked on every request instead of once during init(), error handling is absent in both action handlers (unlike the pattern established in ord-service.js), and MtxOrdProviderService is not blocked in the ORD generation pipeline which will cause it to generate a self-referential API resource in the output document.
PR Bot Information
Version: 1.19.9 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- Correlation ID:
613105f0-2c4e-11f1-9bae-d82726b783da - Agent Instructions:
- File Content Strategy: Full file content
- Event Trigger:
pull_request.ready_for_review - LLM:
anthropic--claude-4.6-sonnet
Introduce MTX ORD Provider Service
New Feature
✨ Adds a new MTX (Multi-Tenancy Extension) ORD (Open Resource Discovery) provider service that exposes endpoints for retrieving ORD documents and resources in a multi-tenant context.
Changes
lib/services/mtx-ord-provider-service.cds: Defines thecds.xt.ord.MtxOrdProviderServiceas a REST service protected byinternal-userauthentication, mounted at/-/cds/ord-provider-service. Exposes two actions:getOrdDocument— retrieves a full ORD document for a given tenant, feature toggles, and runtime (nodejs/java).getOrdResourceDefinition— retrieves a specific ORD resource definition (asLargeString) with the same tenant/toggle/runtime parameters.lib/services/mtx-ord-provider-service.js: Implements the service logic by extendingcds.ApplicationService. Both action handlers delegate tocds.xt.ModelProviderService.getCsn()to resolve the tenant-specific CSN model and then call theord/getMetadatautilities to generate the appropriate response, including setting the correctContent-Typeheader.package.json: Registers the new MTX ORD provider service under the[mtx-sidecar]profile, mapping theSAP ORD Servicemodel to@cap-js/ord/lib/services/mtx-ord-provider-serviceso it is activated automatically in sidecar deployments.📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!
PR Bot Information
Version:
1.19.9| 📖 Documentation | 🚨 Create Incident | 💬 Feedbackpull_request.edited6a8ca730-2c4e-11f1-8789-14023244cff6anthropic--claude-4.6-sonnet