Skip to content

fix: force UTF-8 encoding for non-UTF8 locales #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cardmagic merged 1 commit into from
Jan 1, 2026
Merged

fix: force UTF-8 encoding for non-UTF8 locales #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
classifier (2.3.0)
classifier (2.3.1)
fast-stemmer (~> 1.0)
matrix
mutex_m (~> 0.2)
Expand Down
6 changes: 6 additions & 0 deletions exe/classifier
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#!/usr/bin/env ruby
# frozen_string_literal: true

# Force UTF-8 encoding for proper handling of model data and user input
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: comment restates what the code already shows

Suggested change
# Force UTF-8 encoding for proper handling of model data and user input

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI 
This is a comment left during a code review.
Path: exe/classifier
Line: 4:4

Comment:
**style:** comment restates what the code already shows

```suggestion
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

Encoding.default_external = Encoding::UTF_8
Encoding.default_internal = Encoding::UTF_8

require 'classifier/cli'

result = Classifier::CLI.new(ARGV).run
Expand Down
2 changes: 1 addition & 1 deletion lib/classifier/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Classifier
VERSION = '2.3.0'.freeze
VERSION = '2.3.1'.freeze
end