Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c22d07243
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| module.exports = function (defaults) { | ||
| const app = new EmberApp(defaults, { | ||
| tests: true, |
There was a problem hiding this comment.
Stop bundling the test suite into non-test builds
Setting tests: true on the main EmberApp makes normal ember build outputs include test assets, and this commit also adds /public/live-test.html that loads assets/tests.js, so production deployments now ship and expose the entire host test bundle (including test helpers/mocks) to end users. This is a significant production regression in bundle size and surface area; gate this to test/dev-only builds or move the runner under the /tests test pipeline instead of enabling tests globally.
Useful? React with 👍 / 👎.
Preview deployments |
Run host-like looking test in cards