Skip to content

introduce-realm-enabled-tests#4191

Draft
tintinthong wants to merge 5 commits intomainfrom
is-live-test
Draft

introduce-realm-enabled-tests#4191
tintinthong wants to merge 5 commits intomainfrom
is-live-test

Conversation

@tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Mar 16, 2026

Run host-like looking test in cards

@tintinthong tintinthong changed the title introduce is live test introduce-realm-enabled-tests Mar 16, 2026
@tintinthong tintinthong marked this pull request as draft March 16, 2026 13:17
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c22d07243

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


module.exports = function (defaults) {
const app = new EmberApp(defaults, {
tests: true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Stop bundling the test suite into non-test builds

Setting tests: true on the main EmberApp makes normal ember build outputs include test assets, and this commit also adds /public/live-test.html that loads assets/tests.js, so production deployments now ship and expose the entire host test bundle (including test helpers/mocks) to end users. This is a significant production regression in bundle size and surface area; gate this to test/dev-only builds or move the runner under the /tests test pipeline instead of enabling tests globally.

Useful? React with 👍 / 👎.

@github-actions
Copy link

Preview deployments

@github-actions
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   2h 34m 45s ⏱️ + 4m 59s
2 022 tests ±0  2 007 ✅ ±0  15 💤 ±0  0 ❌ ±0 
2 037 runs  ±0  2 022 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 7c22d07. ± Comparison against base commit 0db3b27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant