validate the data before initializing config to fail fast#11
Open
danialm wants to merge 1 commit intocareo:masterfrom
Open
validate the data before initializing config to fail fast#11danialm wants to merge 1 commit intocareo:masterfrom
danialm wants to merge 1 commit intocareo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config relies on keys being string or symbol (it passes them to Regex#match) but does not validate the input on initialization. So you can initialize it with
{ { foo: :bar } => :baz, foo: :baz }and you only get an error while trying toget(:foo).I was not able to validate the input in any other reliable way. Things like
data.keys.all? Symbole || data.keys.all? Stringordata.keys.all? { |k| k.instance_of?(Symbole) || k.instance_of?(String) }did not work