Conversation
Contributor
|
Just a side comment: It might be good to use a descriptive title for the PR ; having just a number in the commit log isn't as easy. Also, if you mention the number not in the title but in the body of the PR, there will be a msg in ticket #276 that it has been mentioned here. |
Collaborator
Author
|
Sorry, I meant to update the description before removing the Draft status. I hadn't realized it was in its Draft status already causing confusion. 😞 |
* Make sure we publish on TestPyPI * Remove Ubuntu 20.04 from workflow * Build wheels for all Python versions * Use latest version of MacOS * Revert to publishing on PyPI * Revert "Revert to publishing on PyPI" This reverts commit bd1e0a2. * Revert "Build wheels for all Python versions" This reverts commit 700e712. * Run Linux workflow alsowhen tags are created * Switch to MacOS-13 to force Intel-based build * Reapply "Revert to publishing on PyPI" This reverts commit 64c39a6.
Contributor
|
Looks good to me! Unfortunately the macos build fails on some numpy-thing, but I think that's unrelated. |
Collaborator
Author
Indeed. This issue has already been reported: casacore/homebrew-tap#11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current GitHub action that builds and publishes a release, fails to upload the source tar ball. The MR fixes the broken action. The probable cause of this was probably a half-baked upgrade to
v4of theuploadanddownloadactions.