Open
Conversation
gmloose
requested changes
Nov 17, 2025
Collaborator
gmloose
left a comment
gmloose
left a comment
There was a problem hiding this comment.
I think we should drop Python 3.8 support, because the build of the binary wheels now fails on that.
Contributor
Author
|
The build crashed on casacore/casacore#1449 . Also, I want to make a few improvements to get sisco in the wheel. |
Collaborator
|
Curiously, the wheel builds now succeeded, but the build on Ubuntu 22.04 broke. Maybe the version of GCC in that image is too old for C++-20? And the MacOS build failed because it was (again) pointing to a no longer existing casacore data file (we've seen that one before, haven't we). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.