Skip to content

Write install record with transaction hash #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
darthsiroftardis wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Write install record with transaction hash #5371

darthsiroftardis wants to merge 8 commits into from

Conversation

@darthsiroftardis
Copy link
Contributor

@darthsiroftardis darthsiroftardis commented Dec 1, 2025

CHANGELOG:

  • Added a new record to global state that stores the transaction hash of the installer
  • Added a new Key variant called Install

@darthsiroftardis darthsiroftardis self-assigned this Dec 1, 2025
zajko
zajko reviewed Jan 9, 2026
View reviewed changes
execution_engine/src/runtime/mod.rs
.metered_write_gs_unsafe(contract_package_key, contract_package)?;
let current_blocktime = self.context.get_block_info().block_time();

self.context
Copy link
Contributor

@zajko zajko Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only valid for VM1?

Copy link
Contributor Author

@darthsiroftardis darthsiroftardis Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i think it might make sense to add it for VM2 as another PR?

darthsiroftardis
darthsiroftardis commented Jan 12, 2026
View reviewed changes
executor/wasm/src/lib.rs
let contract_key = Key::Hash(smart_contract_addr);
state.metered_write(contract_key, StoredValue::Contract(contract))?;
let cl_value =
CLValue::from_t(transaction_hash).map_err(InstallContractError::CLValueError)?;
Copy link
Contributor Author

@darthsiroftardis darthsiroftardis Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we write the record for VM2 here @zajko

Copy link
Contributor

@zajko zajko Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, missed that - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zajko zajko zajko approved these changes

@mpapierski mpapierski mpapierski approved these changes

@EdHastingsCasperAssociation EdHastingsCasperAssociation EdHastingsCasperAssociation approved these changes

Assignees

@darthsiroftardis darthsiroftardis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darthsiroftardis @zajko @mpapierski @EdHastingsCasperAssociation