Draft
Conversation
29a7ce2 to
74ba99e
Compare
ef6737e to
fccacab
Compare
It seems like sync_catalog will go through the motions but not actually load pins from gems here due to passing an empty requires array to ApiMap. I'm sure those requires get pulled in eventually, but we go through at least one catalog cycle without it happening. Found while trying to test a different issue but not being able to get completions from a gem in a spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been broken into the following parts:
I'll keep this open and use it after these are merged to make sure the result is what I was looking for, but you can disregard this diff entirely.
Original PR description:
Way too much inside - apologies for the large monolithic change:
solargraph gemscaches all cacheable gems/core/stdlibs for a workspace, allowing for CI-based ahead-of-time cachingPerf note
Watching the checks, I was a little worried the plugin regression workflows had slowed down. After isolating things a little more, I think it's possible, but I'm not convinced that more data points won't average this all down to the same thing in the end. I did separate out the plugin regression workflows to tease out impact of each. Here's the data I see:
Specs:
Typechecking
I'd suggest we keep an eye on this, but I am comfortable personally moving forward with this PR in the meantime.
PR complexity note
I'm working now on splitting this into smaller PRs - as those are merged I hope to get this down small enough to be reviewed more easily.
Progress so far:
Next steps: