Set continue_on_error at job level for undercover and rubocop todo#1047
Open
apiology wants to merge 3 commits intocastwide:masterfrom
Open
Set continue_on_error at job level for undercover and rubocop todo#1047apiology wants to merge 3 commits intocastwide:masterfrom
apiology wants to merge 3 commits intocastwide:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now unless someone dives in deep to check, there's no useful feedback to them on whether the undercover or rubocop todo checks succeeded or failed. The UI for pulling out 'exited with error code' otherwise is comically bad :( There's discussion here on that.
With this the mark will be back to red.
To make it clear which what is mandatory and what is optional, I'd suggest setting a branch protection rule on the master branch that requires some (but not undercover and the rubocop todo) checks to pass - I think that will give at least a little better UX to let people know there are things they can dig in on, but that you're not requiring that they do so necessarily - see the 'required' bubble here:
I'll leave the Rubocop TODO check here if you're inclined to fiddle with that setting...
Another idea for undercover is that I can probably rig it up to leave comments in the diff of the PR on the uncovered parts - let me know if you'd prefer that approach.