Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey everyone, thanks for this nice gem, I am trying to incorporate it into more parts of my ruby development.
Sometimes I am using a setup where I do not want to add solargraph to the Gemfile, so I can not start it via bundle exec. However I still want a diagnoser like rubocop to be able to require files of local gems, for example custom cops provided by a local gem (with a path pointer in the local Gemfile).
Currently rubocop will just crash because it can not load those files for custom cop definitions, but with some simple change we can expose the configuration of require_files to rubocop by updating
LOAD_PATH. In many cases require_files already has a working default and there is no additional configuration required.WDYT? @castwide