Conversation
|
Nice! I worry about the schema falling out of date as we add things to the config; it'd be easy to forget that it exists I think. Potential ways to avoid: validate against schema when we generate our default config, use schema to give user good error messages when reading in config. |
When a source code update introduces a syntax error (e.g., an incomplete code snippet that can't be parsed yet), it gets temporarily "repaired" so the source map still works. The update_errors reporter tracks the locations in source that are currently under repair. |
|
@castwide I finished the schema with the additional info |
|
I definitely like the idea of validating the schema. One concern I have, specifically with reporters, is that extensions can add their own reporters. If I'm using solargraph-reek, is there a way to make 'reek' appear as an available reporter? Edit: at the very least, adding 'reek' to the reporters shouldn't be invalid. |
|
Youre right - afaik, its not possible to actually like "register" extra schema modules. I'll add a fallback value. In addition to this, what do you think about pre-registering values for well known modules, like reek/rails/rspec? |
| @@ -0,0 +1 @@ | |||
| ruby 3.2.0 | |||
There was a problem hiding this comment.
Mind opening a separate PR with an explanation if you feel this should be part of the repo?
Adds a JSON Schema for the config file, including docs for each field
Note: yaml lang server had a regression and can't display descriptions for consts/enums in arrays on latest stable version. I have a PR with a potential fix, but we shall see how that goes.
Preview:
Docs were mostly pulled from the solargraph site
Only thing unclear to me, what is the "update_errors" reporter?