[#225] Fix Totara compatibility bug with the core get_directory_size … #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdamsted
force-pushed
the
MOODLE_39_STABLE-totara-compatibility-bug-get-directory-size
branch
from
04c1961 to
1d1be80
Compare
dmitriim
reviewed
Sep 2, 2025
dmitriim
reviewed
Sep 2, 2025
dmitriim
reviewed
Sep 2, 2025
alexdamsted
force-pushed
the
MOODLE_39_STABLE-totara-compatibility-bug-get-directory-size
branch
7 times, most recently
from
9d4cffc to
c0c6c4b
Compare
dmitriim
reviewed
Sep 3, 2025
dmitriim
reviewed
Sep 3, 2025
dmitriim
reviewed
Sep 3, 2025
dmitriim
reviewed
Sep 3, 2025
dmitriim
reviewed
Sep 3, 2025
dmitriim
reviewed
Sep 3, 2025
alexdamsted
force-pushed
the
MOODLE_39_STABLE-totara-compatibility-bug-get-directory-size
branch
3 times, most recently
from
49c670a to
b0d6ecf
Compare
dmitriim
reviewed
Sep 7, 2025
alexdamsted
force-pushed
the
MOODLE_39_STABLE-totara-compatibility-bug-get-directory-size
branch
2 times, most recently
from
cc60c33 to
4661925
Compare
dmitriim
reviewed
Sep 11, 2025
alexdamsted
force-pushed
the
MOODLE_39_STABLE-totara-compatibility-bug-get-directory-size
branch
from
4661925 to
5d2ed00
Compare
dmitriim
deleted the
MOODLE_39_STABLE-totara-compatibility-bug-get-directory-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to solve a bug in issue #225 where the get_directory_size core Totara/Moodle function throws a fatal exception in Totara sites. Moodle has newer code for the function that would resolve this for Totara but to avoid core hacks this PR does a code fork and adds compatibility for Totara.
Replication steps:
if (!empty($CFG->pathtodu) && is_executable(trim($CFG->pathtodu))$allowedbasedirs = array( $CFG->dataroot, $CFG->localcachedir, $CFG->tempdir, $CFG->cachedir, $CFG->dirroot );