fix(helm): rewrite chart with Kubernetes deployment fixes #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing Service and PVC templates - Fix ingress YAML syntax error (host was list instead of scalar) - Replace non-standard encryptAES with randAlphaNum + b64enc for APP_KEY - Replace Bitnami MySQL subchart with built-in MySQL deployment - Add init container to wait for MySQL before starting app - Add --log-bin-trust-function-creators=1 for trigger migrations - Add TCP startup probe for MySQL (socket not available during init) - Mount /var/run, /tmp, framework/cache, framework/sessions as emptyDir - Set S6_CMD_WAIT_FOR_SERVICES_MAXTIME=300000 - Add TLS/cert-manager support to ingress - Add ServiceAccount template - Restructure values.yaml with Bitnami-style @param annotations - Add global.storageClass and existingClaim support Tested on 3-node Hetzner cluster with Longhorn storage, nginx-ingress, and cert-manager. All 144 migrations run successfully, all s6 services start cleanly. Resolves cattr-app#119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the
.helm/chart to fix all known Kubernetes deployment issues from #119. Tested and verified on a production cluster.Fixes
_helpers.tplhostwas a list instead of a scalarencryptAESwithrandAlphaNum+b64enc--log-bin-trust-function-creators=1/var/run,/tmp,framework/cache,framework/sessionsas emptyDirS6_CMD_WAIT_FOR_SERVICES_MAXTIME=300000@paramannotations,global.storageClass,existingClaimsupportTested on
Migration notes
Two Cattr migrations have duplicate table/column creation that fail on fresh installs:
2020_07_21_095849_create_redmine_instances_table— table already created by2020_06_01migration2023_03_09_224051_upgrade_laravel_sanctum_to_3_0—expires_atcolumn already existsWorkaround documented in the related issue #312.
Test plan
helm lint .helm/passeshelm template .helm/renders valid YAMLhelm installon a fresh cluster deploys MySQL + CattrResolves #119
Related: #312