Test subtree-to-inline storage conversion in multimap removal#1256
Merged
Conversation
Extend multimap_remove_subtree_backed_key to keep removing values from the subtree-backed key until enough values are gone that the collection is rewritten back to inline storage, exercising the previously-untested LEAF branch of MultimapTable::remove() and the collapse threshold. Assisted-by: Claude <noreply@anthropic.com>
f866f3e to
992b256
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 88.34% 88.50% +0.16%
==========================================
Files 36 36
Lines 14848 14848
==========================================
+ Hits 13117 13141 +24
+ Misses 1731 1707 -24 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
multimap_remove_subtree_backed_keytest to verify that B-tree subtree storage is correctly converted back to inline storage when removals shrink the data below the threshold.Changes
Implementation Details
The new test section removes 998 out of 999 values for key 0 (keeping only value 500), which causes the B-tree subtree to shrink below the page-size threshold and triggers automatic conversion back to inline storage. This ensures the multimap implementation correctly handles the transition between storage formats during the removal process.
https://claude.ai/code/session_01FPYFdGyznM7nMorDiAK5A2