Implement [Multimap]TableHandle for remaining table types#1260
Merged
cberner merged 1 commit intoMay 20, 2026
Conversation
Implements `TableHandle` for `ReadOnlyUntypedTable`, and `MultimapTableHandle` for `ReadOnlyUntypedMultimapTable` and `ReadOnlyMultimapTable`. The other table types already had `Handle` implementations - this patch expands coverage to all table types. Being able to get the name of a table is useful for logging and error reporting.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
==========================================
- Coverage 88.90% 88.84% -0.06%
==========================================
Files 36 36
Lines 14814 14834 +20
==========================================
+ Hits 13170 13180 +10
- Misses 1644 1654 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
TableHandleforReadOnlyUntypedTable, andMultimapTableHandleforReadOnlyUntypedMultimapTableandReadOnlyMultimapTable. The other table types already hadHandleimplementations - this patch expands coverage to all table types.Being able to get the name of a table is useful for logging and error reporting.