[DO-NOT-MERGE] Add closed captions without transcoding the video content #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a draft commit intended to solicit feedback. This adds support for inserting a DTVCC stream into a H.264 stream as A/53 Part 4 SEI NALs. This allows insertion of EIA-608/CEA-708 closed captions without needing to transcode H.264 video.
This fixes an issue where captions would not be inserted correctly for streams without an AUD NAL.
This gives a handy insertion point for other SEI-based captions streams, like DirecTV and SCTE-20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the MR https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1178 to add missing functionality to
h264parseto add closed captions to H264 content. I've also modified thecccombinerelement to read the picture frame metadata and only add captions to non B-frames buffers. The picture frame metadata is provided by FFMpeg through theavdec_h264element (gstavviddec.c).