Conversation
1) Create madlib.admin.inc file 2) Move to the configuration menu 3) Display on the configuration menu
Adding ajax included rendering the entire madlib, sanitizing user input, if the debug variable is set showing the form again, if the debug varibable isn't set not showing the form, using hook_form_alter, displaying status messages, adding form states, and graceful degradation for non-js enabled clients.
Add ideas for additional items that could be added to the module.
Contributor
There was a problem hiding this comment.
don't translate form keys
Contributor
There was a problem hiding this comment.
Nevermind, you're correct, those are the optgroup labels.
Contributor
|
Cache clear fixed a bunch of things, there's still a mild inconsistency if you submit with no values:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed Madlib Skeleton to Have I got a Giraffe for You!
Render the madlib while sanitizing input and validating input
If debug is set show the form, if it isn't set only show the rendered markup
Use hook_form_alter to inform the user if debug mode is on
Add AJAX