-
Notifications
You must be signed in to change notification settings - Fork 25
Util methods #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Util methods #52
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a489349
Util methods
sawantpritam 08402c5
CDAP-18634
sawantpritam 1a9a55a
review comments
sawantpritam 4f28c99
review comments
sawantpritam 9f71b60
CDAP-18640
sawantpritam bc89b9f
CDAP-18638
sawantpritam c50b576
Methods to create bucket with testdata files
sawantpritam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
src/main/java/io/cdap/e2e/pages/locators/CdfSchemaLocators.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright © 2021 Cask Data, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| package io.cdap.e2e.pages.locators; | ||
|
|
||
| import org.openqa.selenium.WebElement; | ||
| import org.openqa.selenium.support.FindBy; | ||
| import org.openqa.selenium.support.How; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Represents CdfSchemaLocators | ||
| */ | ||
| public class CdfSchemaLocators { | ||
| @FindBy(how = How.XPATH, | ||
| using = "//div[@data-cy='Output Schema']//div[@data-cy='schema-fields-list']//*[@placeholder='Field name']") | ||
| public static List<WebElement> outputSchemaColumnNames; | ||
|
|
||
| @FindBy(how = How.XPATH, using = "//div[@data-cy='Output Schema']//div[@data-cy='schema-fields-list']//select") | ||
| public static List<WebElement> outputSchemaDataTypes; | ||
|
|
||
| @FindBy(how = How.XPATH, | ||
| using = "//div[@data-cy='Input Schema']//div[@data-cy='schema-fields-list']//*[@placeholder='Field name']") | ||
| public static List<WebElement> inputSchemaColumnNames; | ||
|
|
||
| @FindBy(how = How.XPATH, using = "//div[@data-cy='Input Schema']//div[@data-cy='schema-fields-list']//select") | ||
| public static List<WebElement> inputSchemaDataTypes; | ||
|
|
||
| @FindBy(how = How.XPATH, using = "//*[@data-cy='get-schema-btn']//span[text()='Get Schema']") | ||
| public static WebElement getSchemaLoadComplete; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,9 +27,9 @@ | |
| import java.util.Optional; | ||
|
|
||
| /** | ||
| * Represents GcpClient | ||
| * Represents BigQuery Client | ||
| */ | ||
| public class GcpClient { | ||
| public class BigQueryClient { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change will effect SAP ODP PR as well, data-integrations/sap#10. |
||
|
|
||
| private static BigQuery bigQueryService = null; | ||
|
|
||
|
|
@@ -56,7 +56,7 @@ public static void dropBqQuery(String table) throws IOException, InterruptedExce | |
|
|
||
| /** | ||
| * @deprecated | ||
| * Use {@link GcpClient#getSoleQueryResult(String)} instead and parsing needs to be done by caller. | ||
| * Use {@link BigQueryClient#getSoleQueryResult(String)} instead and parsing needs to be done by caller. | ||
| */ | ||
| @Deprecated | ||
| public static int executeQuery(String query) throws InterruptedException, IOException { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add @deprecated annotation here and elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added annotations