Improve P1789 description - #108
Merged
Merged
Conversation
Signed-off-by: Matthias Wippich <mfwippich@gmail.com>
Contributor
Author
|
To be fair, there are uses for this with a single pack/tuple-like. For example, consider a HOF that reverses the argument list: #include <functional>
#include <utility>
template<class F, class... Args>
decltype(auto) reverse_parameter_pack(F&& fnc, Args&&... args) {
static constexpr auto [...Idx] = std::index_sequence_for<Args...>();
return std::invoke(std::forward<F>(fnc),
std::forward<Args...[sizeof...(args)-Idx-1]>(args...[sizeof...(args)-Idx-1])...);
} |
cdervis
reviewed
Mar 9, 2026
cdervis
reviewed
Mar 9, 2026
cdervis
reviewed
Mar 9, 2026
| } | ||
| assert(not is_eq_iile(tup, tup2)); | ||
| assert(not is_eq_fold(tup, tup2)); | ||
| assert(not is_eq_template_for(tup, tup2)); |
Owner
There was a problem hiding this comment.
Let's use ! instead of not, just to be consistent with other example codes across our data files.
Contributor
Author
There was a problem hiding this comment.
I feel like that makes it a lot less readable, but sure :P
Owner
|
Hi @Tsche , thanks for your contribution. I agree with your points, and besides some nitpicks we can definitely integrate this. Could you please make the adjustments I commented? |
Signed-off-by: Matthias Wippich <mfwippich@gmail.com>
Owner
I think your current changes are fine as-is. They get the point across well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous description did not capture the intended use for this feature properly. There is not much point in introducing an index sequence to operate on a single pack/tuple-like - it's more interesting for operating on more than one of those things at the same time.
I've changed the example to a simple tuple comparison - this should showcase how this change can improve pre-C++26 code.
Additionally a few little nitpicks in the "What it does" section:
get, we provide ADL-discoverable overloads