Implemented metadata on Get-SecretInfo#31
Open
chrisjantzen wants to merge 2 commits intocdhunt:mainfrom
Open
Conversation
Author
|
I realized there is a use-case for some of the other data, so I've added some more values to the Metadata. Pretty much everything provided by the It now looks something like this: In my instance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when using
Get-SecretInfoa Metadata attribute is included but empty. When looking at the code I found the Metadata field is part ofGet-SecretInfoandSet-SecretInfoin SecretManagement but was not implemented in this project. 1Password includes version number, created datetime, and updated datetime with theop get listcommand for every password. I have modifiedGet-SecretInfoto include these details in the Metadata property. I have used a hashtable for Metadata as that is the required type according to the SecretManagement documentation.I did not bother implementing this in
Set-SecretInfoas these 3 values all update automatically, so it wouldn't make sense with that command.A new test for the Metadata is included.
Before:
After: