Made the extension module work on MacOS#35
Open
alex-an-dor wants to merge 1 commit intocdhunt:mainfrom
Open
Conversation
* replaced PtrToStringAuto with PtrToStringBSTR for cross-platform compatibility * added IsWindows check to avoid hardcoding op.exe * PtrToStringBSTR is used in the tests too - tests pass * bumped extension module version * also accidentlly may have ran Powershell formatter on the whole psm1 file
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Genuinely interested to make this module work on MacOS as I have a usecase for it
The list of changes as per the commit message:
Tests were ran under MacOS Sequoia 15.5:
Test results:
@cdhunt if you want anything else to be done for this to be merged, I'll be glad to help out