add default sms daily limit

[jzbahrai]

Summary | Résumé

Added a default sms limit to be 1500 over 1000. Only change the default if the current limit is 1000.

Related Issues | Cartes liées

• https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/1
• https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/1

Test instructions | Instructions pour tester la modification

TODO: Fill in test instructions for the reviewer.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

• This PR does not break existing functionality.
• This PR does not violate GCNotify's privacy policies.
• This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
• This PR does not significantly alter performance.
• Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

[Copilot]

Pull request overview

This PR updates the default daily SMS sending limit to 1500 messages/day and migrates existing services that are still on the previous default limit.

Changes:

• Add an Alembic migration to update services.sms_daily_limit from 1000 to 1500 where it is still set to the old default.
• Introduce DEFAULT_SMS_DAILY_LIMIT = 1500 and use it as the fallback in Service.from_json.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
migrations/versions/0508_update_daily_sms_limit.py	Data migration to bump daily SMS limit from 1000 → 1500 for services still using the old default.
app/models.py	Add a daily SMS default constant and apply it when deserializing a Service from JSON.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[smcmurtry]

I tried the upgrade and downgrade locally, it worked.