Properly implement handler::update_host
#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterTh
reviewed
Dec 17, 2024
PeterTh
approved these changes
Dec 17, 2024
Refactor buffer_state to type-erase the allocator and allow embedding pointers to that state into accessors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was not callable so far, it simply referenced an unimplemented function on
accessorof the same name.Calling
buffer_state::write_backrequires the state to be available insideaccessor, which is why I refactoredbufferto internally expose itsstaterather than pointers and ranges individually. This in turn needs type erasure on Allocator, which I quickly added as well.