Fix implementation of handler::fill
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterTh
approved these changes
Dec 17, 2024
Collaborator
PeterTh
left a comment
PeterTh
left a comment
There was a problem hiding this comment.
What/how was it failing before?
Collaborator
Author
|
The function was not previously covered at all, and I got an overload resolution error on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fillis just a kernel, it was implemented with the internalsequential_forhelper instead ofhandler::parallel_for- not sure exactly what didn't work, but afaic this is the more straightforward implementation anyway.