Add configuration of CSI driver liveness sidecar to helm deploy and label generated services#549
Add configuration of CSI driver liveness sidecar to helm deploy and label generated services#549promasu wants to merge 4 commits into
Conversation
Currently the liveness settings are part of the DriverType spec but are not configurable or can't be enabled via Helm. This commits allows this configuration. Signed-off-by: Adrian Nöthlich <git@promasu.tech>
Adds labels to the liveness sidecar service so it can be automatically discovered by a Prometheus ServiceMonitor. The app label matches the included ServiceMonitor in the Rook Helm chart. Signed-off-by: Adrian Nöthlich <git@promasu.tech>
Signed-off-by: Adrian Nöthlich <git@promasu.tech>
Signed-off-by: Adrian Nöthlich <git@promasu.tech>
|
@promasu Thanks for the PR, the liveness is deprecated in csi and we are planning to remove it, so we dont have any plan to add it to the csi-operator |
|
Hi @Madhu-1 I tried to find out if this was let out on purpose and was not find anything about this. I was not able to locate any deprecation notice for liveness in CSI spec, so I'd happy if you could point me in that direction. But you are totally right, if liveness is deprecated in CSI, then this PR is senseless. |
@promasu yes its not documented anywhere but its was on maintainers decision to not invest on it as its deprecated and removed soon. |
|
@Madhu-1 It still shows as stable in the CSI docs https://kubernetes-csi.github.io/docs/livenessprobe.html |
we have not added liveness provided by the kubernetes-csi yet, PTAL ceph/ceph-csi#5599 and ceph/ceph-csi#1096. one to remove native liveness in cephcsi another is to add supports for kubernetes-csi liveness |
2 participants
Describe what this PR does
Adds configuration of liveness sidecar to helm deploy and label generated services
Is there anything that requires special attention
Rook allows adding a ServiceMonitor for the CSI drivers. Currently this option is of no use, as there is no way to enable the liveness sidecar when deploying with Helm.
Related issues
Future concerns
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.