feat(settings and input bar): add option for toggling spell check #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new spellcheck setting to disable spell checking in the Cerebro app's input bar to address user feedback about distracting squiggly underlines while typing.
- Added a new boolean configuration option
spellcheckwith default valuefalse - Added a checkbox control in the settings UI to toggle the spellcheck feature
- Connected the spellcheck setting to the main input bar's
spellCheckattribute
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/lib/config.js | Added spellcheck configuration schema with default false value |
| app/plugins/core/settings/Settings/index.js | Added spellcheck state management and UI checkbox control |
| app/main/components/Cerebro/index.js | Applied spellcheck config to the main input bar component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
PeterDaveHello
left a comment
PeterDaveHello
left a comment
There was a problem hiding this comment.
The subject line is too long.
To address cerebroapp#712 we introduce a spellcheck boolean setting to control the spellCheck attribute of the input bar. By disabling the spellcheck members will not see a squiggly line under the text while they input it. re cerebroapp#712
emilioidk
force-pushed
the
add-spellcheck-setting
branch
from
9f6aa72 to
21d8c3a
Compare
emilioidk
changed the title
Contributor
Author
I have amended it now to a shorter subject |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #712 we introduce a spellcheck boolean setting to control the spellCheck attribute of the input bar. By disabling the spellcheck members will not see a squiggly line under the text while they input it.
re #712