Merged
Conversation
hwigwanglim
requested changes
Jan 20, 2026
Contributor
There was a problem hiding this comment.
I downloaded the repository to execute the server and everything looks great! One thing I'd like to mention is that the images are a bit large (~20 MB) so they can cause the delay and/or a lot of data usage when loading your page.
(assets/img/james_yeom.png, assets/img/james_yeom_1.png, assets/img/james_yeom_2.png) Charles' bird photos have the same issue so he gets blamed every time it comes up haha
If you could lower their size to the order of 1-2 MB, we're good to go!
Contributor
Author
|
Ok I think everything should be good now |
cajchristian
approved these changes
Jan 21, 2026
Contributor
cajchristian
left a comment
cajchristian
left a comment
There was a problem hiding this comment.
This looks good! Feel free to squash and merge
hwigwanglim
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.