chore: add linting, formatting, and CI quality gates#8
Merged
Conversation
Add ESLint, Prettier, and jsx-a11y with cached local lint commands. Add GitHub Actions quality checks and protect main with the required quality status. Apply the initial formatting pass and fix lint and accessibility issues to keep check green.
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review Summary by QodoAdd ESLint, Prettier, and GitHub Actions CI quality gates with codebase formatting
WalkthroughsDescription• Add ESLint flat-config with TypeScript, React, JSX accessibility, and React Hooks support • Add Prettier code formatter with project-wide configuration and ignore rules • Create GitHub Actions CI workflow for automated quality checks (formatting, linting, tests, build) • Add npm scripts for code quality: format, format:check, lint, lint:fix, and check • Apply initial formatting pass across entire codebase to comply with new quality gates • Fix accessibility issues including removal of redundant role="region" attribute • Update README with documentation for new quality commands and CI/branch protection requirements • Add VSCode extension recommendations for ESLint and Prettier • Configure branch protection with required quality status checks and strict up-to-date enforcement • Exclude pnpm-lock.yaml from formatter to prevent unnecessary churn Diagramflowchart LR
A["ESLint Config<br/>eslint.config.js"] --> B["Code Quality<br/>Enforcement"]
C["Prettier Config<br/>.prettierrc.json"] --> B
D["Ignore Rules<br/>.prettierignore"] --> B
B --> E["GitHub Actions<br/>CI Workflow"]
E --> F["Quality Checks<br/>format/lint/test/build"]
F --> G["Branch Protection<br/>on main"]
H["Codebase<br/>Formatting Pass"] --> B
I["npm Scripts<br/>package.json"] --> B
File Changes |
Code Review by Qodo
1. ESLint lints build artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add ESLint, Prettier, and jsx-a11y with repo-level scripts and configuration.
Add a GitHub Actions quality workflow for formatting, linting, tests, and build, with concurrency cancellation for superseded runs.
Protect main with the required quality status check and strict up-to-date enforcement.
Details
Introduce flat-config ESLint with TypeScript, React Hooks, React Refresh, and accessibility rules.
Add Prettier config and ignore rules, including excluding pnpm-lock.yaml from formatter churn.
Apply the initial formatting pass across the repo and fix follow-on lint, type-safety, and accessibility issues needed to keep the new gate green.
Refresh README command docs and CI guidance to match the enforced workflow.
Validation
pnpm format:check
pnpm lint
pnpm test:run
pnpm build
pnpm check