Skip to content

docs(test): align MVP contract and expand e2e coverage#9

Merged
cesarnml merged 1 commit intomainfrom
codex/mvp-reconciliation
Mar 28, 2026
Merged

docs(test): align MVP contract and expand e2e coverage#9
cesarnml merged 1 commit intomainfrom
codex/mvp-reconciliation

Conversation

@cesarnml
Copy link
Copy Markdown
Owner

Summary
Clarifies the shipped MVP so the repo’s active contract matches the implementation: PDF download only, fixed A4 output, current font scope, and phase 2 gated on MVP alignment rather than scope growth.

Adds fresh-worktree bootstrap guidance so pnpm install is treated as the first required step before interpreting failed checks, and introduces a PRD 2 slice model to keep the next planning phase small, testable, and context-safe.

Expands Playwright smoke coverage for the current product surface, including preset apply/clear flows, manual character selection, layout clamping feedback, PDF export progress, export failure UX, and mobile-flow sanity.

Testing
Ran pnpm check
Ran pnpm test:e2e

Clarify the shipped MVP as PDF-only with fixed A4 output and current font scope.
Document fresh-worktree bootstrap expectations and add a PRD 2 slice model.
Expand Playwright smoke coverage for preset flows, manual selection, layout clamping, export progress, export failure, and mobile sanity.
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
thai-script-pro Ready Ready Preview, Comment Mar 28, 2026 7:34am

@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Align MVP contract and expand Playwright E2E coverage

📝 Documentation 🧪 Tests ✨ Enhancement

Grey Divider

Walkthroughs

Description
• Expands Playwright E2E coverage with nine new smoke tests covering preset flows, manual selection,
  layout clamping, export progress, and failure handling
• Documents MVP contract explicitly: PDF-only output, fixed A4 paper size, current font scope, and
  phase 2 gating criteria
• Adds fresh-worktree bootstrap guidance and PRD 2 slice model for structured phase 2 planning
• Clarifies verification status and aligns CURRENT_STATE.md as source of truth for shipped MVP
Diagram
flowchart LR
  A["MVP Contract<br/>Clarification"] --> B["Documentation<br/>Updates"]
  C["E2E Test<br/>Expansion"] --> D["Playwright<br/>Coverage"]
  E["Bootstrap<br/>Guidance"] --> F["Developer<br/>Workflow"]
  G["PRD 2<br/>Planning"] --> H["Phase 2<br/>Structure"]
  B --> I["Aligned<br/>Repository"]
  D --> I
  F --> I
  H --> I
Loading

Grey Divider

File Changes

1. e2e/smoke.spec.ts 🧪 Tests +124/-13

Expand Playwright smoke coverage with nine focused tests

• Replaces single desktop flow test with nine focused smoke tests covering distinct user paths
• Adds preset apply/clear tests for consonants and vowels with selection count verification
• Adds manual character selection test validating preview content updates
• Adds layout clamping test verifying column and ghost-copy constraints with feedback messages
• Adds PDF export progress test with download interception and button state validation
• Adds PDF export failure test with error toast and recovery state verification
• Adds mobile viewport test for responsive sanity checking

e2e/smoke.spec.ts


2. README.md 📝 Documentation +20/-1

Document MVP contract and bootstrap guidance

• Adds MVP contract section documenting PDF-only output, fixed A4 size, and current font scope
• Updates pnpm install command description to emphasize it as required first step in fresh
 worktree
• Adds fresh worktree bootstrap section with recommended workflow and verification order

README.md


3. docs/CURRENT_STATE.md 📝 Documentation +20/-3

Establish MVP contract as source of truth

• Updates date to March 28, 2026 and adds source-of-truth statement for shipped MVP
• Adds MVP locked decisions section explicitly documenting PDF-only output, A4-only paper size,
 current font scope, and phase 2 gating criteria
• Updates constraints section to clarify A4-only targeting and adds Playwright coverage status
• Adds verification status section documenting Vitest and Playwright coverage and fresh-worktree
 requirements

docs/CURRENT_STATE.md


View more (2)
4. docs/PRD_02_SLICE_MODEL.md 📝 Documentation +35/-0

Introduce PRD 2 slice model for phase 2 planning

• New file introducing PRD 2 slice model for structured phase 2 planning
• Defines gates before PRD 2 work: MVP contract alignment, fresh-worktree verification, and
 Playwright coverage
• Specifies required slice shape with user outcome, UI changes, state changes, and test acceptance
 criteria
• Recommends four phase 2 slices in priority order: saved presets, export parity, guided workflows,
 and new content
• Establishes slice rules for independent releasability and focused scope

docs/PRD_02_SLICE_MODEL.md


5. src/components/VowelDisplay.tsx Formatting +1/-4

Minor formatting adjustment

• Reformats import statement to single line for consistency

src/components/VowelDisplay.tsx


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Mar 28, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@cesarnml cesarnml merged commit 72fe5bc into main Mar 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant