docs(test): align MVP contract and expand e2e coverage#9
Merged
Conversation
Clarify the shipped MVP as PDF-only with fixed A4 output and current font scope. Document fresh-worktree bootstrap expectations and add a PRD 2 slice model. Expand Playwright smoke coverage for preset flows, manual selection, layout clamping, export progress, export failure, and mobile sanity.
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review Summary by QodoAlign MVP contract and expand Playwright E2E coverage
WalkthroughsDescription• Expands Playwright E2E coverage with nine new smoke tests covering preset flows, manual selection, layout clamping, export progress, and failure handling • Documents MVP contract explicitly: PDF-only output, fixed A4 paper size, current font scope, and phase 2 gating criteria • Adds fresh-worktree bootstrap guidance and PRD 2 slice model for structured phase 2 planning • Clarifies verification status and aligns CURRENT_STATE.md as source of truth for shipped MVP Diagramflowchart LR
A["MVP Contract<br/>Clarification"] --> B["Documentation<br/>Updates"]
C["E2E Test<br/>Expansion"] --> D["Playwright<br/>Coverage"]
E["Bootstrap<br/>Guidance"] --> F["Developer<br/>Workflow"]
G["PRD 2<br/>Planning"] --> H["Phase 2<br/>Structure"]
B --> I["Aligned<br/>Repository"]
D --> I
F --> I
H --> I
File Changes1. e2e/smoke.spec.ts
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the shipped MVP so the repo’s active contract matches the implementation: PDF download only, fixed A4 output, current font scope, and phase 2 gated on MVP alignment rather than scope growth.
Adds fresh-worktree bootstrap guidance so pnpm install is treated as the first required step before interpreting failed checks, and introduces a PRD 2 slice model to keep the next planning phase small, testable, and context-safe.
Expands Playwright smoke coverage for the current product surface, including preset apply/clear flows, manual character selection, layout clamping feedback, PDF export progress, export failure UX, and mobile-flow sanity.
Testing
Ran pnpm check
Ran pnpm test:e2e