Skip to content

Improve karls-picture.typ - #1118

Closed
yerlotic wants to merge 4 commits into
cetz-package:0.5.3from
yerlotic:master
Closed

Improve karls-picture.typ#1118
yerlotic wants to merge 4 commits into
cetz-package:0.5.3from
yerlotic:master

Conversation

@yerlotic

@yerlotic yerlotic commented Jul 8, 2026

Copy link
Copy Markdown
  • Fix spelling mistakes in comments
  • Make angle into a variable
  • Fix rendering for angles > 90 degrees

- Fix spelling mistakes in comments
- Make angle into a variable
- Fix rendering for angles > 90 degrees
@johannes-wolf

Copy link
Copy Markdown
Member

Thank you for this PR, but it does not fix angles > 90°. You can use (angle, 1) for polar coordinates instead of (cos(angle), sin(angle)) btw. You are right, the example needs some cleanup and fixes.

@johannes-wolf
johannes-wolf self-requested a review July 10, 2026 19:20
Comment thread gallery/karls-picture.typ Outdated
Comment thread gallery/karls-picture.typ Outdated
Comment thread gallery/karls-picture.typ
yerlotic and others added 3 commits July 12, 2026 17:09
Co-authored-by: Johannes Wolf <mail@johannes-wolf.com>
Co-authored-by: Johannes Wolf <mail@johannes-wolf.com>
@yerlotic

Copy link
Copy Markdown
Author

So I changed some things in bd31aaf

  • Added corner rounding to math elements on top of a graph
  • Changed the angle to 212°
  • Added a label to the angle
  • Changed stroke: (paint: sth) to stroke: sth
  • Added a secondary grid (and it would be cool to strip the borders from the grid from all 4 sides, but idk how to do it)

Feel free to undo any of the changes you find unnecessary

This is how it looks like now:

fancy version

@johannes-wolf
johannes-wolf self-requested a review July 12, 2026 17:41
@johannes-wolf
johannes-wolf changed the base branch from master to 0.5.3 July 13, 2026 08:42
@johannes-wolf

Copy link
Copy Markdown
Member

Pushed this branch + changes on #1120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants