Adjusted peer related examples in regards to hostname -f versus sys.fqhost (3.21) #5626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sadly, my change doesn't work. Even here in github I get Will look more carefully at what is going on. |
craigcomstock
changed the title
…qhost This was breaking on some systems in a way that doesn't benefit the test. Instead of assuming that `hostname -f` is equal to `sys.fqhost` just use `sys.fqhost` in the first place. Ticket: ENT-12437 Changelog: none (cherry picked from commit 9c05580)
craigcomstock
force-pushed
the
ENT-12437/3.21
branch
from
a835677 to
051dbce
Compare
craigcomstock
changed the title
craigcomstock
changed the title
Contributor
Author
|
just missing windows msi package, not a big deal, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was breaking on some systems in a way that doesn't benefit the test.
Instead of assuming that
hostname -fis equal tosys.fqhostjust usesys.fqhostin the first place.Ticket: ENT-12437
Changelog: none
(cherry picked from commit 471dc0f)