libpromises/evalfunction: Do not crash w/o arguments

[btriller]

Do not crash cf-promises if no argument is given for following functions:

• readfile
• iprange
• isipinsubnet

[CLAassistant]

All committers have signed the CLA.

[larsewi]

Great, thanks 🚀 You can easily fix the CodeQL alerts by adding

assert(fp != NULL);

in the top of the function block. Let me know if you want me to fix this for you.

In the mean while we can ask @cf-bottom to test this in Jenkins

[olehermanse]

@cf-bottom jenkins, please

[cf-bottom]

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11443/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11443/

[olehermanse]

@btriller Thank you for your contribution, merging. Your fixes will probably not make it into the releases we're working on now (3.24.1 and 3.21.6), but will be a part of the next ones (3.25.0, 3.24.2, and 3.21.7).

[btriller]

@btriller Thank you for your contribution, merging. Your fixes will probably not make it into the releases we're working on now (3.24.1 and 3.21.6), but will be a part of the next ones (3.25.0, 3.24.2, and 3.21.7).

Ping

[larsewi]

Back-ports:

• libpromises/evalfunction: Do not crash w/o arguments (3.24.x) #5668
• libpromises/evalfunction: Do not crash w/o arguments (3.21.x) #5669