Skip to content

ENT-13522: verify_databases.c: Various bug fixes in CreateTableColumns() #5975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsewi merged 4 commits into from
Dec 4, 2025
Merged

ENT-13522: verify_databases.c: Various bug fixes in CreateTableColumns() #5975

larsewi merged 4 commits into from
Dec 4, 2025
+30 −28

Conversation

@larsewi
Copy link
Contributor

@larsewi larsewi commented Dec 3, 2025 •
edited
Loading

  • Changed severity of log level in CreateTableColumns()
  • Fixed use of uninitialized buffer in CreateTableColumns()
  • Fixed buffer overflow in CreateTableColumns()
  • cf_sql.{c,h}: constified arguments in DB query functions

Backported to:

@larsewi
Changed severity of log level in CreateTableColumns()
59f11a5 
Changed the severity of the log message "Trying to create table..." from
`LOG_LEVEL_ERR` to `LOG_LEVEL_VERBOSE`.

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
Fixed use of uninitialized buffer in CreateTableColumns()
832ad34 
Fixed potential bug causing an uninitialized buffer (containing garbage
data) to be sent as a database query when creating a table in the
databases promise type.

Changelog: Commit
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
Fixed buffer overflow in CreateTableColumns()
ff4f9a6 
Fixed potential buffer overflow when creating tables using the databases
promise type.

Ticket: ENT-13552
Changelog: Commit
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
cf_sql.{c,h}: constified arguments in DB query functions
6b6a90d 
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi marked this pull request as ready for review December 3, 2025 11:40
@larsewi
Copy link
Contributor Author

larsewi commented Dec 3, 2025

@cf-bottom Jenkins please :)

@cf-bottom
Copy link

cf-bottom commented Dec 3, 2025

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/13106/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13106/

This was referenced Dec 3, 2025
Merged
Merged
@larsewi larsewi merged commit d95e8a0 into cfengine:master Dec 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

@olehermanse olehermanse Awaiting requested review from olehermanse

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larsewi @cf-bottom @craigcomstock