Force bar chart to show monthly data on large screens instead of faking quarterly data#168
Draft
Force bar chart to show monthly data on large screens instead of faking quarterly data#168
Conversation
…es instead of double tests
Merged
Member
|
@cfarm Can this be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://GHE/CFGOV/platform/issues/3275 in the short term. Additional data releases in the future may cause issues with the "All" months view no longer fitting into the chart. Note that this is already the case with the small screen, "mobile" view of the bar charts- those still show false quarterly numbers with this PR.
Main changes in this are:
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist