Add guard that checks if secondary nav is defined#2539
Merged
anselmbradford merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
anselmbradford
force-pushed
the
ans_sidebar_search
branch
3 times, most recently
from
0db4f27 to
704f5cd
Compare
anselmbradford
force-pushed
the
ans_sidebar_search
branch
from
704f5cd to
9bae8d1
Compare
itsmedavep
approved these changes
Apr 3, 2026
Collaborator
itsmedavep
left a comment
itsmedavep
left a comment
There was a problem hiding this comment.
I pulled the branch and tested this out. I do not see any errors in dev tools console.
Looks good to me. Approved!
anselmbradford
force-pushed
the
ans_sidebar_search
branch
from
9bae8d1 to
1db0895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search page doesn't have the secondary nav, so throws the error
Uncaught TypeError: Cannot read properties of null (reading 'setAttribute')in the dev console. This PR adds a guard to check if the secondary nav exists before trying to do scripting with it.Changes
Testing
yarn buildand start local server.