Skip to content
This repository was archived by the owner on Oct 29, 2025. It is now read-only.

Fix type inconsistency in sql#91

Open
cmc333333 wants to merge 325 commits intocfpb:masterfrom
cmc333333:postgres-type-error
Open

Fix type inconsistency in sql#91
cmc333333 wants to merge 325 commits intocfpb:masterfrom
cmc333333:postgres-type-error

Conversation

@cmc333333
Copy link
Contributor

Resolves #90 generically by casting strings as ints in the queries.

dlapiduz and others added 30 commits April 8, 2014 11:15
Search results, various updates for Idea fields
Add a smoke test for the home page
Remove voter field from forms, add migrations
Do some CSS work and add listing voting
Add notifications when installed in collab
…brown-custom_comments

Conflicts:
	src/idea/templates/idea/detail.html
Conflicts:
	src/idea/static/idea/css/idea.css
	src/idea/templates/idea/detail.html
Fix fontawesome icon for Read More link in IE
m3brown and others added 27 commits December 9, 2014 14:20
Tests now run when bundled with collab
Add private room capability
Add optional anonymity for private rooms
README changes: IdeaBox is not hypenated. Django is capitalized
Update taggit info in README
@cmc333333
Copy link
Contributor Author

1be6da6 is the important commit; everything else is merging in the remove-buildout branch so that Travis can run

@m3brown
Copy link
Contributor

m3brown commented Nov 6, 2015

Can we get some more background on this? My understanding based on the branch name and commit message is the old style doesn't quite work right for postgresql, but apparently works fine in mysql and sqlite?

It doesn't look like we have any tests for comment_count or recent_activity... perhaps it'd make sense to add those to this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants