Skip to content

Make test_infinite_output_command more reliable #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 1 commit into from
Apr 11, 2025
Merged

Make test_infinite_output_command more reliable #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,13 +1172,19 @@ fn test_absolute_deadline_kills_infinite_loop_command() {

#[test]
fn test_infinite_output_command() {
// test for commands like `yes`
run_async_test(|| async {
let mut cmd = StdCommand::new("yes");
cmd.arg("infinite");
// Use a simpler infinite command that's more reliable than 'yes'
// because yes tries as to maximize CPU usage by
// generating output as fast as possible in an infinite loop
// without any delay between repetitions
let mut cmd = StdCommand::new("bash");
cmd.arg("-c")
.arg("while true; do echo 'test'; sleep 0.1; done");

let min_timeout = Duration::from_secs(1);
let max_timeout = Duration::from_secs(2); // Absolute deadline of 2 seconds
let activity_timeout = Duration::from_secs(1); // Activity timeout of 1 second
let max_timeout = Duration::from_secs(2);
let activity_timeout = Duration::from_secs(1);

let result = run_command_with_timeout(cmd, min_timeout, max_timeout, activity_timeout)
.await
Expand All @@ -1196,11 +1202,11 @@ fn test_infinite_output_command() {
result.exit_status.is_some(),
"Exit status should be Some after timeout"
);
// SIGKILL is signal 9

assert_eq!(
result.exit_status.unwrap().signal(),
Some(libc::SIGKILL as i32),
"Should be killed by SIGKILL"
"Should be killed by SIGKILL" // SIGKILL is signal 9
);
assert!(result.timed_out, "Should have timed out");
assert!(
Expand Down
Loading