Highlights Improvements #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Song <jmadeson@amazon.com>
Signed-off-by: Madeleine <madeleinejsong@gmail.com>
Signed-off-by: Madeleine <madeleinejsong@gmail.com>
cgalvan
reviewed
Aug 9, 2022
|
|
||
| #option 3: add a pulse effect | ||
| if self.width < 50 and self.height < 50: | ||
| update_widget(self, event) |
Owner
There was a problem hiding this comment.
The update_widget only needs to be called when you are choosing a new widget/item to highlight. I think what you meant to use was update which will trigger the highlight to be repainted. Instead of calling it in the paintEvent method though, you should call it outside of here on a timed loop at a certain interval (maybe 500ms?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 new options improving the highlight visibility of a very small widget:
-highlight the content of the widget itself (shade it)
-highlight the area around the widget not including the widget
-add a pulse effect. i think that this is breaking the tutorial. i have a feeling that i am incorrectly calling the update method for the highlight widget.