Adapt Everest/ccc guide regarding EVerest 2024.9.0 release #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
…support Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
…0 release (refs EVEREST-1291) Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
…ntation Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
lategoodbye
requested changes
Jan 9, 2025
barsnick
requested changes
Jan 9, 2025
Contributor
barsnick
left a comment
barsnick
left a comment
There was a problem hiding this comment.
Two minor comments, otherwise a great improvement.
| **API** (`view on GitHub <https://github.com/EVerest/everest-core/tree/main/modules/API>`__) | ||
|
|
||
| This module is not mandatory for an EVSE setup using Charge Control C in EVerest. However, the module | ||
| :code:`API` is responsible to provide a simple MQTT based API to EVerest internals. |
Contributor
There was a problem hiding this comment.
Suggested change
| :code:`API` is responsible to provide a simple MQTT based API to EVerest internals. | |
| :code:`API` is responsible for providing a simple MQTT based API to EVerest internals. |
docs/source/getting_started.rst
Outdated
|
|
||
| Snippet of a EVerest configuration file: | ||
|
|
||
| .. code-block:: sh |
Contributor
There was a problem hiding this comment.
Could this be formatted as YAML, or would that active peculiar colors?
Suggested change
| .. code-block:: sh | |
| .. code-block:: yaml |
I can't seem to find a proper list of supported languages. I looked at this list. I hope it's the one that applies. sh isn't even mentioned, nor is console.
Contributor
Author
There was a problem hiding this comment.
I also have changed the types of the other console outputs from sh -> console
Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
lategoodbye
approved these changes
Jan 9, 2025
barsnick
approved these changes
Jan 9, 2025
FaHaGit
deleted the
everest/ccc_update_guide_regarding_EVerest_2024.9.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.