Skip to content

Conversation

@wscourge
Copy link
Contributor

@wscourge wscourge commented Dec 26, 2025

  • Added deprecation warning to Subscription.list_imported() method
  • Added CustomerSubscription import to customer module
  • Updated tests to use correct imports and assertions

@wscourge wscourge requested a review from Copilot December 26, 2025 10:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR deprecates CustomerSubscription.list_imported() in favor of a new Customer.subscriptions() method and updates documentation examples to use correct field names.

  • Adds new Customer.subscriptions() method for retrieving customer subscriptions
  • Marks CustomerSubscription.list_imported() as deprecated with a warning
  • Corrects field names from external_id to uuid in subscription connection examples

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
chartmogul/api/customer.py Adds new Customer.subscriptions() method
chartmogul/api/customers/subscription.py Implements deprecation warning for list_imported() method
test/api/test_customer.py Adds test coverage for new subscriptions() method and updates field names in existing tests
README.md Documents new subscriptions() method and corrects field names in examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant