Skip to content

chore: Update from ubi8/nodejs-18:1-71 to ubi8/nodejs-18:1-81 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickboldt merged 8 commits into from
Nov 21, 2023
Merged

chore: Update from ubi8/nodejs-18:1-71 to ubi8/nodejs-18:1-81 #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2073b90
chore: Update from ubi8/nodejs-18:1-71 to ubi8/nodejs-18:1-81
nickboldt Nov 18, 2023
b2f67ad
install node-gyp globally
azatsarynnyy Nov 20, 2023
66247d4
Update linux-libc.Dockerfile
azatsarynnyy Nov 20, 2023
229a427
Update build/dockerfiles/linux-libc.Dockerfile
nickboldt Nov 20, 2023
6645ca6
add node gyp 9.4.1 as a dep; add node/npm/yarn versions as engines
nickboldt Nov 20, 2023
3af326a
Add node-gyp to yarn.lock
nickboldt Nov 20, 2023
c39f3c2
remove node-gyp global install
azatsarynnyy Nov 21, 2023
548dd61
Revert "remove node-gyp global install"
nickboldt Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build/dockerfiles/linux-libc.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#

# https://registry.access.redhat.com/ubi8/nodejs-18
FROM registry.access.redhat.com/ubi8/nodejs-18:1-71 as linux-libc-builder
FROM registry.access.redhat.com/ubi8/nodejs-18:1-81 as linux-libc-builder

USER root

Expand Down Expand Up @@ -47,7 +47,8 @@ RUN { if [[ $(uname -m) == "s390x" ]]; then LIBSECRET="\
fi; } \
&& yum install -y $LIBSECRET $LIBKEYBOARD curl make cmake gcc gcc-c++ python3.9 git git-core-doc openssh less libX11-devel libxkbcommon bash tar gzip rsync patch \
&& yum -y clean all && rm -rf /var/cache/yum \
&& npm install -g yarn@1.22.17
&& npm install -g yarn@1.22.17 \
&& npm install -g node-gyp@9.4.1

#########################################################
#
Expand Down
10 changes: 9 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,13 @@
"build:min": "cd code && yarn gulp vscode-reh-web-linux-x64-min",
"rebuild-native-modules": "cd code && npm rebuild"
},
"license": "EPL-2.0"
"license": "EPL-2.0",
"dependencies": {
"node-gyp": "^9.4.1"
},
"engines": {
"node": ">= 18.18.2",
"npm": ">= 9.8.1",
"yarn": ">= 1.22.19"
}
}
17 changes: 17 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,20 @@
# yarn lockfile v1


node-gyp@9.4.1:
version "9.4.1"
resolved "https://registry.npmjs.org/node-gyp/-/node-gyp-9.4.1.tgz#8a1023e0d6766ecb52764cc3a734b36ff275e185"
integrity sha512-OQkWKbjQKbGkMf/xqI1jjy3oCTgMKJac58G2+bjZb3fza6gW2YrCSdMQYaoTb70crvE//Gngr4f0AgVHmqHvBQ==
dependencies:
env-paths "^2.2.0"
exponential-backoff "^3.1.1"
glob "^7.1.4"
graceful-fs "^4.2.6"
make-fetch-happen "^10.0.3"
nopt "^6.0.0"
npmlog "^6.0.0"
rimraf "^3.0.2"
semver "^7.3.5"
tar "^6.1.2"
which "^2.0.2"