Skip to content

Cleans up the root package.json #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azatsarynnyy merged 1 commit into from
Nov 23, 2023
Merged

Cleans up the root package.json #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,5 @@
"build:min": "cd code && yarn gulp vscode-reh-web-linux-x64-min",
"rebuild-native-modules": "cd code && npm rebuild"
},
"license": "EPL-2.0",
"dependencies": {
"node-gyp": "^9.4.1"
Copy link
Member Author

@azatsarynnyy azatsarynnyy Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing node-gyp from npm was a breaking change introduced in npm/cli#6932.
They already fixed the problem in npm/cli#6932.

While a new version of Node.js with the fixed npm has not yet been released, the only temporary workaround that we need on the Che-Code side is installing node-gyp globally to allow any transitive dependency rely on it. Once we update to a newer Node.js, we can get rid of that ^^ workaround.

Anyway, if it was even decided that node-gyp was no longer part of npm, we don't need to declare any transitive dependency of VS Code in Che-Code's root package.json.

},
"engines": {
Copy link
Member Author

@azatsarynnyy azatsarynnyy Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS Code build has a custom check of the node/yarn versions on the preinstall phase. I believe there's not much sense in introducing one more very similar verification. So, I suggest relying only on the verification script from upstream.

Copy link
Collaborator

@RomanNikitenko RomanNikitenko Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moreover: it broke the che-in-che development: eclipse-che/che#22686

"node": ">= 18.18.2",
"npm": ">= 9.8.1",
"yarn": ">= 1.22.19"
}
"license": "EPL-2.0"
}
17 changes: 0 additions & 17 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,3 @@
# yarn lockfile v1


node-gyp@9.4.1:
version "9.4.1"
resolved "https://registry.npmjs.org/node-gyp/-/node-gyp-9.4.1.tgz#8a1023e0d6766ecb52764cc3a734b36ff275e185"
integrity sha512-OQkWKbjQKbGkMf/xqI1jjy3oCTgMKJac58G2+bjZb3fza6gW2YrCSdMQYaoTb70crvE//Gngr4f0AgVHmqHvBQ==
dependencies:
env-paths "^2.2.0"
exponential-backoff "^3.1.1"
glob "^7.1.4"
graceful-fs "^4.2.6"
make-fetch-happen "^10.0.3"
nopt "^6.0.0"
npmlog "^6.0.0"
rimraf "^3.0.2"
semver "^7.3.5"
tar "^6.1.2"
which "^2.0.2"