Avoid the direct dependency to node-gyp since it's bundled with npm#403
Avoid the direct dependency to node-gyp since it's bundled with npm#403azatsarynnyy merged 1 commit intomainfrom
node-gyp since it's bundled with npm#403Conversation
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64 |
2 similar comments
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64 |
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64 |
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
azatsarynnyy
force-pushed
the
no_node-gyp
branch
from
1618b36 to
f607559
Compare
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-403-amd64 |
azatsarynnyy
changed the title
node-gyp since it's bundled with npm
azatsarynnyy
requested review from
RomanNikitenko and
vitaliy-guliy
as code owners
|
Build 3.17 :: code_3.x/1472: Console, Changes, Git Data |
|
Build 3.17 :: code_3.x/1472: Upstream sync done; No sync or Brew build |
3 participants
What does this PR do?
We used to directly depend on
node-gypbecause it was removed fromnpmin npm/cli#6554.Since
node-gypis part ofnpmagain (see npm/cli#6932), there's no need to keep having a direct dependency and maintaining the version up to date.More technical details: npm/cli#6554 (comment)
What issues does this PR fix?
related to https://github.com/redhat-developer/devspaces-images/pull/627
How to test this PR?
See the passed PR status checks.
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder