Issue #13491: Simplify setterHaveSinceTag

[DakshRJain737]

Issue: #13491

Simplified setterHaveSinceTag by seperating the method check and class check.

Added new internal check SetterSinceTagCheck.
contribution: checkstyle/contribution#1036

[DakshRJain737]

@romani Is a custom check necessary for this according to you?

[romani]

items:

[DakshRJain737]

@romani Done, Added a new internal check that removes the need for setterHaveSinceTag Xpath quere.
Please review it.

[DakshRJain737]

Working on CI.

[romani]

we cannot expose this Check to public, it does not make any sense out of Checkstyle code base.

[romani]

until CI is green , humas do no review

[DakshRJain737]

until CI is green , humas do no review

I was trying to figure out how internal checks are written.
I couldn't understand the way they are present. I was trying to figure that out.

[romani]

Please read and watch videos at Starting_Development.
few last videos focusng on how to read CIs

[DakshRJain737]

done

[DakshRJain737]

Any changes??

[DakshRJain737]

@romani Please review

[DakshRJain737]

@romani CI Failures seem to fail because of other reasons.

[romani]

please make extra commit with mistake in code to show that it actually violates code if someone forget to do this.

[DakshRJain737]

please make extra commit with mistake in code to show that it actually violates code if someone forget to do this.

Yes the test is working fine and clearly able to find the violation

[DakshRJain737]

@romani Should i revert back the change if the results are satisfactory?

[DakshRJain737]

@romani ping
Good to merge

[DakshRJain737]

@romani ping..

[DakshRJain737]

@romani good to merge.

[DakshRJain737]

@romani Pending from long time. Good to merge

[romani]

tested, works:

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessarySemicolonInTryWithResourcesCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessarySemicolonInTryWithResourcesCheck.java
index 0bb7c5f997..4edf236861 100644
--- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessarySemicolonInTryWithResourcesCheck.java
+++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessarySemicolonInTryWithResourcesCheck.java
@@ -72,7 +72,6 @@ public final class UnnecessarySemicolonInTryWithResourcesCheck extends AbstractC
      * Setter to allow unnecessary semicolon if closing parenthesis is not on the same line.
      *
      * @param allowWhenNoBraceAfterSemicolon a value to set.
-     * @since 8.22
      */
     public void setAllowWhenNoBraceAfterSemicolon(boolean allowWhenNoBraceAfterSemicolon) {
         this.allowWhenNoBraceAfterSemicolon = allowWhenNoBraceAfterSemicolon;

runs

Setter 'setAllowWhenNoBraceAfterSemicolon' in 'UnnecessarySemicolonInTryWithResourcesCheck' must have a @since tag
expected to be true

	at com.puppycrawl.tools.checkstyle.internal.AllChecksTest.testAllChecksOrFiltersSettersHaveSinceTag(AllChecksTest.java:635)