Skip to content

Escape all knife wrapper arguments to prevent shell command injection #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tas50 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Escape all knife wrapper arguments to prevent shell command injection #4203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/chef-server-ctl/plugins/wrap-knife.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,16 +117,13 @@ def self.parse_args(args)
auth_args << "-c" << knife_config
# auth_args << "--config-option" << "ssl_verify_mode=verify_none"

# Build command args - don't escape config options with = signs
# Build command args. Escape every argument before it is interpolated
# into the shell command string. Shellwords.escape leaves benign
# characters (including "=") untouched, so "key=value" style config
# options still pass through unchanged, while shell metacharacters in
# any argument are neutralized rather than executed.
all_args = transformed_args + auth_args
escaped_args = all_args.map do |arg|
# Don't escape arguments that contain = (like config options)
if arg.include?('=')
arg
else
Shellwords.escape(arg)
end
end.join(" ")
escaped_args = all_args.map { |arg| Shellwords.escape(arg) }.join(" ")

knife_command = "#{knife_cmd} #{opc_noun} #{opc_cmd} #{escaped_args}"
status = run_command(knife_command)
Expand Down
Loading