Skip to content

URL-encode credentials in PostgreSQL connection URI #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tas50 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

URL-encode credentials in PostgreSQL connection URI #4206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/chef-server-ctl/lib/chef_server_ctl/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require "chef_server_ctl/log"
require "chef-utils/dist"
require "erb"

# ChefServerCtl::Config is a global configuration class for
# ChefServerCtl subcommands.
Expand Down Expand Up @@ -148,7 +149,15 @@ def self.make_connection_string(db_name, db_user, db_password)
pg_config = @@ctl.running_service_config("postgresql")
host = pg_config["vip"]
port = pg_config["port"]
"postgresql:///#{db_name}?user=#{db_user}&password=#{db_password}&host=#{host}&port=#{port}"
# URL-encode the credentials. A username or password containing
# characters that are significant in a libpq connection URI (such as
# '&', '?', '#', '/', or spaces) would otherwise break the URI or
# inject additional connection parameters. The DB superuser password,
# for example, can be set to an arbitrary value via
# set-db-superuser-password.
user = ERB::Util.url_encode(db_user.to_s)
password = ERB::Util.url_encode(db_password.to_s)
"postgresql:///#{db_name}?user=#{user}&password=#{password}&host=#{host}&port=#{port}"
end

def self.ssl_params
Expand Down
Loading